Skip to content

printf-in-get-text-func-call (INT003)

Added in v0.0.260 · Related issues · View source

Derived from the flake8-gettext linter.

What it does

Checks for printf-style formatted strings in gettext function calls.

Why is this bad?

In the gettext API, the gettext function (often aliased to _) returns a translation of its input argument by looking it up in a translation catalog.

Calling gettext with a formatted string as its argument can cause unexpected behavior. Since the formatted string is resolved before the function call, the translation catalog will look up the formatted string, rather than the printf-style template.

Instead, format the value returned by the function call, rather than its argument.

Example

from gettext import gettext as _

name = "Maria"
_("Hello, %s!" % name)  # Looks for "Hello, Maria!".

Use instead:

from gettext import gettext as _

name = "Maria"
_("Hello, %s!") % name  # Looks for "Hello, %s!".

References